Merge pull request #129 from str4d/78-ignore-readers-without-piv-applet

Ignore smart cards that don't have a PIV applet
This commit is contained in:
str4d
2023-03-23 06:40:39 +00:00
committed by GitHub
2 changed files with 12 additions and 0 deletions
+1
View File
@@ -120,6 +120,7 @@ cli-setup-finished =
open-yk-with-serial = ⏳ Please insert the {-yubikey} with serial {$yubikey_serial}. open-yk-with-serial = ⏳ Please insert the {-yubikey} with serial {$yubikey_serial}.
open-yk-without-serial = ⏳ Please insert the {-yubikey}. open-yk-without-serial = ⏳ Please insert the {-yubikey}.
warn-yk-not-connected = Ignoring {$yubikey_name}: not connected warn-yk-not-connected = Ignoring {$yubikey_name}: not connected
warn-yk-missing-applet = Ignoring {$yubikey_name}: Missing {$applet_name} applet
print-recipient = Recipient: {$recipient} print-recipient = Recipient: {$recipient}
+11
View File
@@ -49,6 +49,17 @@ pub(crate) fn filter_connected(reader: &Reader) -> bool {
); );
false false
} }
Err(yubikey::Error::AppletNotFound { applet_name }) => {
warn!(
"{}",
fl!(
"warn-yk-missing-applet",
yubikey_name = reader.name(),
applet_name = applet_name,
),
);
false
}
Err(_) => true, Err(_) => true,
Ok(yubikey) => { Ok(yubikey) => {
// We only connected as a side-effect of confirming that we can connect, so // We only connected as a side-effect of confirming that we can connect, so