james/yubikey.rs
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

tool: check length before trying to store cert in buffer

Browse Source 
fixes #148
This commit is contained in:
Klas Lindfors
2018-08-16 14:49:32 +02:00
parent 16d539041e
commit 45e74cfccf
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tool/yubico-piv-tool.c
+6
View File
@@ -561,6 +561,12 @@ static bool import_cert(ykpiv_state *state, enum enum_key_format cert_format,
unsigned char certdata[YKPIV_OBJ_MAX_SIZE]; unsigned char certdata[YKPIV_OBJ_MAX_SIZE];
unsigned char *certptr = certdata; unsigned char *certptr = certdata;
ykpiv_rc res; ykpiv_rc res;
if(cert_len > YKPIV_OBJ_MAX_SIZE) {
fprintf(stderr, "Length of certificate is more than can fit.\n");
goto import_cert_out;
}
if (compress) { if (compress) {
if (fread(certdata, 1, (size_t)cert_len, input_file) != (size_t)cert_len) { if (fread(certdata, 1, (size_t)cert_len, input_file) != (size_t)cert_len) {
fprintf(stderr, "Failed to read compressed certificate\n"); fprintf(stderr, "Failed to read compressed certificate\n");