From 7ff30070172f53e2d810ceb951687e3a9abc0e7f Mon Sep 17 00:00:00 2001 From: Dave Pate Date: Tue, 22 Jan 2019 07:29:24 -0800 Subject: [PATCH] lib: clear secrets in ykpiv_import_private_key --- lib/ykpiv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/ykpiv.c b/lib/ykpiv.c index 854ccc1..258fa0a 100644 --- a/lib/ykpiv.c +++ b/lib/ykpiv.c @@ -1695,7 +1695,8 @@ ykpiv_rc ykpiv_import_private_key(ykpiv_state *state, const unsigned char key, u padding = elem_len - lens[i]; remaining = (uintptr_t)key_data + sizeof(key_data) - (uintptr_t)in_ptr; if (padding > remaining) { - return YKPIV_ALGORITHM_ERROR; + res = YKPIV_ALGORITHM_ERROR; + goto Cleanup; } memset(in_ptr, 0, padding); in_ptr += padding;