From 89d8a60876e16f7ce6bc582ce5c6651eb623de5b Mon Sep 17 00:00:00 2001
From: Alessio Di Mauro <alessio@yubico.com>
Date: Thu, 11 Aug 2016 14:30:40 +0200
Subject: [PATCH] Return CKR_FUNCTION_FAILED for unimplemented func

Closes #84
---
 ykcs11/ykcs11.c | 80 ++++++++++++++++++++++++-------------------------
 1 file changed, 40 insertions(+), 40 deletions(-)

diff --git a/ykcs11/ykcs11.c b/ykcs11/ykcs11.c
index 19fd60b..72745ec 100644
--- a/ykcs11/ykcs11.c
+++ b/ykcs11/ykcs11.c
@@ -284,7 +284,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_WaitForSlotEvent)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_GetMechanismList)(
@@ -711,7 +711,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_GetOperationState)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_SetOperationState)(
@@ -725,7 +725,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_SetOperationState)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_Login)(
@@ -1094,7 +1094,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_CopyObject)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_DestroyObject)(
@@ -1203,7 +1203,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_GetObjectSize)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_GetAttributeValue)(
@@ -1262,7 +1262,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_SetAttributeValue)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_FindObjectsInit)(
@@ -1455,7 +1455,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_EncryptInit)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_Encrypt)(
@@ -1469,7 +1469,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_Encrypt)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_EncryptUpdate)(
@@ -1483,7 +1483,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_EncryptUpdate)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_EncryptFinal)(
@@ -1495,7 +1495,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_EncryptFinal)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_DecryptInit)(
@@ -1507,7 +1507,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_DecryptInit)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_Decrypt)(
@@ -1521,7 +1521,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_Decrypt)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_DecryptUpdate)(
@@ -1535,7 +1535,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_DecryptUpdate)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_DecryptFinal)(
@@ -1547,7 +1547,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_DecryptFinal)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_DigestInit)(
@@ -1608,7 +1608,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_Digest)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_DigestUpdate)(
@@ -1620,7 +1620,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_DigestUpdate)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_DigestKey)(
@@ -1631,7 +1631,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_DigestKey)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_DigestFinal)(
@@ -1643,7 +1643,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_DigestFinal)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_SignInit)(
@@ -1939,7 +1939,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_SignUpdate)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_SignFinal)(
@@ -1951,7 +1951,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_SignFinal)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_SignRecoverInit)(
@@ -1963,7 +1963,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_SignRecoverInit)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_SignRecover)(
@@ -1977,7 +1977,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_SignRecover)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_VerifyInit)(
@@ -1989,7 +1989,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_VerifyInit)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_Verify)(
@@ -2003,7 +2003,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_Verify)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_VerifyUpdate)(
@@ -2015,7 +2015,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_VerifyUpdate)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_VerifyFinal)(
@@ -2027,7 +2027,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_VerifyFinal)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_VerifyRecoverInit)(
@@ -2039,7 +2039,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_VerifyRecoverInit)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_VerifyRecover)(
@@ -2053,7 +2053,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_VerifyRecover)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_DigestEncryptUpdate)(
@@ -2067,7 +2067,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_DigestEncryptUpdate)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_DecryptDigestUpdate)(
@@ -2081,7 +2081,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_DecryptDigestUpdate)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_SignEncryptUpdate)(
@@ -2095,7 +2095,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_SignEncryptUpdate)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_DecryptVerifyUpdate)(
@@ -2109,7 +2109,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_DecryptVerifyUpdate)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_GenerateKey)(
@@ -2123,7 +2123,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_GenerateKey)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_GenerateKeyPair)(
@@ -2301,7 +2301,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_WrapKey)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_UnwrapKey)(
@@ -2318,7 +2318,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_UnwrapKey)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_DeriveKey)(
@@ -2333,7 +2333,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_DeriveKey)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 /* Random number generation functions */
@@ -2347,7 +2347,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_SeedRandom)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_GenerateRandom)(
@@ -2359,7 +2359,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_GenerateRandom)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_GetFunctionStatus)(
@@ -2369,7 +2369,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_GetFunctionStatus)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_DEFINE_FUNCTION(CK_RV, C_CancelFunction)(
@@ -2379,7 +2379,7 @@ CK_DEFINE_FUNCTION(CK_RV, C_CancelFunction)(
   DIN;
   DBG("TODO!!!");
   DOUT;
-  return CKR_OK;
+  return CKR_FUNCTION_FAILED;
 }
 
 CK_FUNCTION_LIST function_list = {