Fix test cases: uninitialized memory and non-terminated string compare
This commit is contained in:
@@ -138,7 +138,7 @@ static void test_token_info() {
|
||||
if (info.firmwareVersion.major != 4 && info.firmwareVersion.major != 0)
|
||||
asrt(info.firmwareVersion.major, 4, "FW_MAJ");
|
||||
|
||||
asrt(strcmp(info.utcTime, TOKEN_TIME), 0, "TOKEN_TIME");
|
||||
asrt(strncmp(info.utcTime, TOKEN_TIME, sizeof(info.utcTime)), 0, "TOKEN_TIME");
|
||||
|
||||
asrt(funcs->C_Finalize(NULL), CKR_OK, "FINALIZE");
|
||||
|
||||
|
||||
@@ -182,6 +182,7 @@ CK_RV create_token(ykpiv_state *state, CK_BYTE_PTR p, ykcs11_slot_t *slot) {
|
||||
|
||||
t_info->ulFreePrivateMemory = CK_UNAVAILABLE_INFORMATION;
|
||||
|
||||
memset(&t_info->hardwareVersion, 0, sizeof(t_info->hardwareVersion));
|
||||
// Ignore hardware version, report firmware version
|
||||
if (token.get_token_version(state, &t_info->firmwareVersion) != CKR_OK) {
|
||||
ykpiv_disconnect(state);
|
||||
|
||||
Reference in New Issue
Block a user