james/yubikey.rs
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix an old overflow bug

Browse Source 
we need to do 8 - new_len, not 16 - new_len which overflows the indata
buffer
This commit is contained in:
Klas Lindfors
2015-12-08 14:12:29 +01:00
parent 1f1b61bcf9
commit e7d53ceb45
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tool/yubico-piv-tool.c
+1 -1
View File
@@ -1013,7 +1013,7 @@ static bool change_pin(ykpiv_state *state, enum enum_action action, const char *
} }
memcpy(indata + 8, new_pin, new_len); memcpy(indata + 8, new_pin, new_len);
if(new_len < 8) { if(new_len < 8) {
memset(indata + 8 + new_len, 0xff, 16 - new_len); memset(indata + 8 + new_len, 0xff, 8 - new_len);
} }
if(ykpiv_transfer_data(state, templ, indata, sizeof(indata), data, &recv_len, &sw) != YKPIV_OK) { if(ykpiv_transfer_data(state, templ, indata, sizeof(indata), data, &recv_len, &sw) != YKPIV_OK) {
return false; return false;