lib: clear secrets in ykpiv_import_private_key

2019-01-22 07:29:24 -08:00
parent a10ab1ace5
commit 7ff3007017
1 changed files with 2 additions and 1 deletions
@@ -1695,7 +1695,8 @@ ykpiv_rc ykpiv_import_private_key(ykpiv_state *state, const unsigned char key, u
    padding = elem_len - lens[i];
    remaining = (uintptr_t)key_data + sizeof(key_data) - (uintptr_t)in_ptr;
    if (padding > remaining) {
-      return YKPIV_ALGORITHM_ERROR;
+      res = YKPIV_ALGORITHM_ERROR;
+      goto Cleanup;
    }
    memset(in_ptr, 0, padding);
    in_ptr += padding;